Skip to content

[Compute] Update Compute client version to 23.0.0.#4809

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
hyonholee:september
Sep 28, 2018
Merged

[Compute] Update Compute client version to 23.0.0.#4809
dsgouda merged 1 commit intoAzure:psSdkJson6from
hyonholee:september

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

@hyonholee hyonholee commented Sep 27, 2018 •
edited
Loading

Including shared gallery APIs, List VM by Location API, Diff disk support, and Ultra SSD support.

Azure/azure-rest-api-specs#3080

Azure/azure-rest-api-specs#3854

Azure/azure-rest-api-specs#3944

Azure/azure-rest-api-specs#3983

Azure/azure-rest-api-specs#3984

Azure/azure-rest-api-specs#3896

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

shahabhijeet
shahabhijeet approved these changes Sep 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes. This is good to merge

dsgouda
dsgouda approved these changes Sep 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyonholee
Update Compute client version to 23.0.0.
21c5255 
Including shared gallery APIs, List VM by Location API, Diff disk support, and Ultra SSD support.
@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Sep 27, 2018

Will merge when CI builds pass

@dsgouda dsgouda merged commit 848055f into Azure:psSdkJson6 Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dsgouda dsgouda dsgouda approved these changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyonholee @dsgouda @shahabhijeet